fix(sveltekit): Fix <meta> tag injection
#7612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
approved these changes
Mar 27, 2023
AbhiPrasad
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed in my test app that apparently the
%sveltekit.head%isn't present in the html that's passed totransformPageChunk. Hence our<meta>tag injection logic introduced in #7574 didn't find the anchor point where to inject the tags. This PR fixes the injection, by simply appending it to an open<head>tag. It's not pretty but it should do the trick 🤞 (we can revisit if this breaks folks).Tested with one of my kit test apps and now, FE and BE transactions are connected:
ref #7526